[BFT] Epoch Recovery integration test #6823
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/efm-recovery #6823 +/- ##
========================================================
- Coverage 41.81% 41.73% -0.08%
========================================================
Files 1588 2033 +445
Lines 144098 181227 +37129
========================================================
+ Hits 60251 75642 +15391
- Misses 78887 99361 +20474
- Partials 4960 6224 +1264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
approved these changes
Dec 20, 2024
| // enters Epoch Fallback Mode can successfully recover. | ||
| // For this specific scenario, we are testing a scenario where the consensus committee and Random Beacon committee form a symmetric difference with | ||
| // cardinality 1. In other words, there is a node which is part of the consensus committee but not part of the Random Beacon committee and | ||
| // another node which is part of the Random Beacon committee but not part of the consensus committee. |
There was a problem hiding this comment.
Suggested change
| // another node which is part of the Random Beacon committee but not part of the consensus committee. | |
| // another node which is part of the Random Beacon committee but not part of the consensus committee. | |
| // We remove the first consensus node from the Consensus Committee, and the last consensus node from the Random Beacon Committee: | |
| // If the original consensus set is {A, B, C, D} then: | |
| // - the post-recovery consensus committee is {B, C, D} | |
| // - the post-recovery random beacon committee is {A, B, C} | |
| // |
| internalNodePrivInfoDir, nodeConfigJson := s.getNodeInfoDirs(flow.RoleConsensus) | ||
| internalNodes, err := common.ReadFullInternalNodeInfos(unittest.Logger(), internalNodePrivInfoDir, nodeConfigJson) | ||
| require.NoError(s.T(), err) | ||
| // 3. Eject consensus node by modifying the snapshot before generating the recover epoch transaction args. |
There was a problem hiding this comment.
Suggested change
| // 3. Eject consensus node by modifying the snapshot before generating the recover epoch transaction args. | |
| // 3. Eject the FIRST consensus node by modifying the snapshot before generating the recover epoch transaction args. |
| dkgIndexMap := make(flow.DKGIndexMap, nConsensusNodes) | ||
| for i, participant := range randomBeaconParticipants[:nConsensusNodes] { | ||
| dkgIndexMap[participant.NodeID] = i | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| dkgKeyShares := dkg.KeyShares()[:nConsensusNodes] |
Putting this next to the corresponding index map construction logic
| 3000, | ||
| false, | ||
| dkgIndexMap, | ||
| dkg.KeyShares()[:nConsensusNodes], |
There was a problem hiding this comment.
Suggested change
| dkg.KeyShares()[:nConsensusNodes], | |
| dkgKeyShares, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6645
Context
This PR implements the most general case where Random beacon committee and consensus committee form a symmetric difference with cardinality 1. More details in the attached issue.